ExchangeFetchAssignment deleting the wrong config #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lied configuration using the old ExchangeFetch class has a couple of errors in it. These errors mean that the ExchangeFetchAssignment ignores all configuration passed to it, if there's configurations for the ExchangeFetch class in the config file. (The ExchangeReleaseAssignment is correct as it is.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for displaying warning and updating config when a user supplied configuration using the old ExchangeFetch class has a couple of errors in it.
These errors mean that the ExchangeFetchAssignment ignores all configuration passed to it, if there's configurations for the ExchangeFetch class in the config file.
This is especially bad if someone has partially updated an old config file and accidentally left some references to ExchangeFetch in it, while correctly updating other references.
(The ExchangeReleaseAssignment is correct as it is.)