Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demos using Python3 #1281

Merged
merged 3 commits into from
Nov 12, 2019
Merged

Demos using Python3 #1281

merged 3 commits into from
Nov 12, 2019

Conversation

Patil2099
Copy link
Contributor

Fixes #1261

@Patil2099
Copy link
Contributor Author

@jhamrick Do I have to make changes in Travis and Azure file also?

@jhamrick
Copy link
Member

jhamrick commented Nov 6, 2019 •
edited
Loading

Thanks!

Would you mind also making the other change from #1261:

Added mkdir -p /etc/jupyter/ before cp global_nbgrader_config.py /etc/jupyter/nbgrader_config.py in setup_demo.sh because the directory did not exist, so the copy command would fail.

You shouldn't need to make any changes to travis or azure.

@jhamrick jhamrick added the bugfix label Nov 6, 2019
@jhamrick jhamrick added this to the 0.6.1 milestone Nov 6, 2019
jhamrick
jhamrick requested changes Nov 6, 2019
View reviewed changes
demos/restart_demo.sh Outdated Show resolved Hide resolved
@jhamrick jhamrick modified the milestones: 0.6.1, 0.6.2 Nov 6, 2019
@Patil2099
Copy link
Contributor Author

@jhamrick Is it Correct Now?

@Patil2099 Patil2099 requested a review from jhamrick November 9, 2019 16:52
@jhamrick
Copy link
Member

There was one other change it would be great if you could make, see #1281 (comment). Thanks!

@Patil2099
Copy link
Contributor Author

@jhamrick Is this correct now?

@jhamrick
Copy link
Member

Yes, looks good, thanks!

I think the test failures are unrelated, so I will go ahead and merge.

@jhamrick jhamrick merged commit 4c5d6f6 into jupyter:master Nov 12, 2019
BertR added a commit that referenced this pull request Mar 16, 2021
@BertR
Backport PR #1281: Demos using Python3
15dda9d 
Fixes #1261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamrick jhamrick Awaiting requested review from jhamrick

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
0.6.2
Development

Successfully merging this pull request may close these issues.

Demos: ensure /etc/jupyter exists and use Python 3
2 participants
@Patil2099 @jhamrick