Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formgrader API #1228

Merged
merged 1 commit into from
Nov 2, 2019
Merged

Fix formgrader API #1228

merged 1 commit into from
Nov 2, 2019

Conversation

BertR
Copy link
Contributor

@BertR BertR commented Sep 26, 2019

Formgrader was using the default course id for every call to the Gradebook.
By passing in the course id, every assignment in the gradebook will be created
with the course_id that was set in the config.

@BertR BertR added the bugfix label Sep 26, 2019
@BertR BertR requested a review from jhamrick September 26, 2019 14:17
Copy link
Member

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @BertR

@jhamrick
Copy link
Member

jhamrick commented Nov 2, 2019

Thanks!

@jhamrick jhamrick merged commit 5d4032c into jupyter:master Nov 2, 2019
@jhamrick jhamrick added this to the 0.6.1 milestone Nov 6, 2019
@jhamrick
Copy link
Member

jhamrick commented Nov 6, 2019

@meeseeksdev backport to 0.6.x

meeseeksmachine pushed a commit to meeseeksmachine/nbgrader that referenced this pull request Nov 6, 2019
jhamrick added a commit that referenced this pull request Nov 7, 2019
…8-on-0.6.x

Backport PR #1228 on branch 0.6.x (Fix formgrader API)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants