Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "nbgrader assign" to "nbgrader generate_assignment" #1137

Merged
merged 5 commits into from
Jun 11, 2019

Conversation

jhamrick
Copy link
Member

@jhamrick jhamrick commented Jun 2, 2019

Fixes #1136

cc @rkdarst

FYI @dsblank @danielmaitre : a similar amount of stuff will need to change to rename nbgrader feedback to nbgrader generate_feedback, hence my suggestion to do it in a separate PR 🙂

We may also want to do further renamings:

  • release --> release_assignment
  • fetch --> fetch_assignment

I will probably wait until the other big PRs are merged (#1131, #1120) before merging this one to avoid too many merge conflicts.

@jhamrick jhamrick added this to the 0.6.0 milestone Jun 2, 2019
@jhamrick jhamrick force-pushed the deprecate-assign branch 3 times, most recently from 26af095 to ef1ee30 Compare June 6, 2019 08:25
@jhamrick jhamrick merged commit 1d56f23 into jupyter:master Jun 11, 2019
@jhamrick jhamrick deleted the deprecate-assign branch June 11, 2019 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"generate" (formgrader) and "assign" (command line) refer to same thing
1 participant