Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure course directory root path has no trailing slashes #1123

Merged
merged 3 commits into from
Jun 2, 2019

Conversation

jhamrick
Copy link
Member

@jhamrick jhamrick commented Jun 1, 2019

Fixes #1008

This standardizes the path to the course directory root so that it is an absolute path, and adds a test to be sure that the trailing slashes are indeed removed.

@jhamrick jhamrick added the bugfix label Jun 1, 2019
@jhamrick jhamrick added this to the 0.6.0 milestone Jun 1, 2019
@jhamrick jhamrick merged commit 660fd17 into jupyter:master Jun 2, 2019
@jhamrick jhamrick deleted the fix-trailing-slash branch June 2, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misbehavior if root directory ends with /
1 participant