Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for multiple classes #1114

Merged
merged 10 commits into from
Jun 3, 2019

Conversation

sigurdurb
Copy link
Contributor

@sigurdurb sigurdurb commented May 31, 2019

Documentation on how to setup Multiple classes with No authentication, Jupyterhub authentication and Custom authentication.

Revisions welcome.
@jhamrick @BertR @damianavila

@jhamrick jhamrick changed the title Mc docs Documentation for multiple classes May 31, 2019
@jhamrick
Copy link
Member

One thing I'm thinking it might be useful to add to this as well is a table specifying the configuration options for different extensions for different users when you have separate services for the formgraders. Something like this:

Students Instructors Formgraders
Create Assignment no no yes
Assignment List yes yes no
Formgrader no no yes
Course List no yes no

@sigurdurb
Copy link
Contributor Author

Yes! Where to enable which extension. Will put it in there.

Copy link
Member

@jhamrick jhamrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice---thanks for taking the time to write all these docs!

Copy link
Member

@jhamrick jhamrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there I think 🙂

Can you also add the table I suggested in #1114 (comment) ?

@sigurdurb
Copy link
Contributor Author

@jhamrick Got the table in, we could make a separate chapter just for the extensions but this should be good for now.

Copy link
Member

@jhamrick jhamrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks great! I think this is ready to merge. I think the test failure should be spurious, but re-running just in case. Will merge once all the tests pass.

@jhamrick
Copy link
Member

jhamrick commented Jun 3, 2019

Hooray, the tests pass! Merging now 🙂 Thanks for all your work on this @sigurdurb!

@jhamrick jhamrick merged commit c957818 into jupyter:multiple-classes-dev Jun 3, 2019
@sigurdurb sigurdurb deleted the mc_docs branch June 3, 2019 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants