Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional consistency check between owner and student_id upon collect #1111

Merged
merged 4 commits into from
Jun 3, 2019
Merged

Optional consistency check between owner and student_id upon collect #1111

merged 4 commits into from
Jun 3, 2019

Conversation

nthiery
Copy link
Contributor

@nthiery nthiery commented May 31, 2019

Mitigates #1097, #1098.

@nthiery
Copy link
Contributor Author

nthiery commented May 31, 2019

Hmm, this may require a nowindows decorator. Let's see what the tests say.

jhamrick
jhamrick approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@jhamrick jhamrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks! I think here the nowindows mark shouldn't be explicitly necessary as I believe it's added elsewhere (to the whole test class I think), but we'll see I guess 🙂

@jhamrick jhamrick added this to the 0.6.0 milestone May 31, 2019
@jhamrick jhamrick merged commit 0a0359e into jupyter:master Jun 3, 2019
@nthiery nthiery deleted the check_owner_student_id branch June 3, 2019 22:00
@nthiery
Copy link
Contributor Author

nthiery commented Jun 3, 2019

Thank you Jessica for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamrick jhamrick jhamrick approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nthiery @jhamrick