Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spellcheck and enchant dependency #1051

Merged
merged 2 commits into from
Dec 15, 2018
Merged

Remove spellcheck and enchant dependency #1051

merged 2 commits into from
Dec 15, 2018

Conversation

jhamrick
Copy link
Member

@jhamrick jhamrick added this to the 0.6.0 milestone Dec 15, 2018
willingc
willingc approved these changes Dec 15, 2018
View reviewed changes
Copy link
Member

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jhamrick. If we see more Travis failures on warnings, we may want to relax to errors.

@jhamrick jhamrick merged commit 02dba76 into jupyter:master Dec 15, 2018
@jhamrick jhamrick deleted the remove-spelling branch December 15, 2018 18:42
@willingc
Copy link
Member

@jhamrick Were you waiting to press the green button? 😉

@jhamrick
Copy link
Member Author

😏 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc approved these changes

Assignees
No one assigned
Labels
documentation maintenance
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

pyenchant is unmaintained
2 participants
@jhamrick @willingc