Dev requirements and spelling tests #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, is the Travis build getting a very old version of pytest that actually needs |
willingc
approved these changes
Dec 7, 2018
|
Thanks! The sphinx spellchecker used to cause Travis to error out, but it no longer does. I'm tempted to remove the spell check because it's a bit of a pain and as you pointed out you have to check the logs manually. But that's something to leave for a later PR. |
jhamrick
added a commit
to jhamrick/nbgrader
that referenced
this pull request
Dec 15, 2018
- remove cov-core per @jedbrown jupyter#1045 - add more recent python versions - update to newer travis build parameters
jhamrick
added a commit
to jhamrick/nbgrader
that referenced
this pull request
Dec 15, 2018
I don't know whether this PR should go to 'master' or '0.5.x'. Should Travis tests be made to regard spelling errors as errors? (It appears that you have to check the logs to see if any errors are identified.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know whether this PR should go to 'master' or '0.5.x'. Should Travis tests be made to regard spelling errors as errors? (It appears that you have to check the logs to see if any errors are identified.)