Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to notebook directory when validating (repeat of #880) #1002

Merged
merged 2 commits into from
Oct 7, 2018

Conversation

rkdarst
Copy link
Contributor

@rkdarst rkdarst commented Aug 10, 2018

There is in fact a test for this, but perhaps pytest chdirs to the ipynb's directory so that the test can't fail.

I'm still making my final tests but this seems to work.

@jhamrick
Copy link
Member

jhamrick commented Oct 6, 2018

Looks good, thanks! Should I merge this or did you still want to add a test?

@jhamrick jhamrick added this to the 0.6.0 milestone Oct 6, 2018
@rkdarst
Copy link
Contributor Author

rkdarst commented Oct 7, 2018

It's easy to merge now, but I guess then tests will never come. I probably won't get around to tests soon, so you can decide what you'd like to do.

I seem to remember checking, and the problem was that pytest directly executes notebooks. And chdirs to the notebook directory before executing it. So there would have to be another layer that pytest runs, which runs another the actual test on a notebook in another dir. (This memory could be wrong).

rkdarst and others added 2 commits October 7, 2018 17:54
- This was fixed in jupyter#880, but a refactoring to split reading from
  preprocessing has removed the wrapper around the preprocess step.
@jhamrick jhamrick force-pushed the relative_path_validation branch from 1408710 to 84e1f5f Compare October 7, 2018 16:55
@jhamrick
Copy link
Member

jhamrick commented Oct 7, 2018

I've added a test which is fixed by this change, and will merge once it passes. Thanks!

@rkdarst
Copy link
Contributor Author

rkdarst commented Oct 7, 2018

Thanks a lot! Let's hope it works.

@jhamrick jhamrick merged commit ade3fa3 into jupyter:master Oct 7, 2018
@rkdarst rkdarst deleted the relative_path_validation branch December 31, 2018 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants