Skip to content

Commit

Permalink
Remove jupyter_notebook_config.json since notebook server is not supp…
Browse files Browse the repository at this point in the history
…orted anymore (#1807)

* Move etc/jupyter/jupyter_notebook_config.json to etc/jupyter/jupyter_notebook_config.d/nbgrader.json

There is already jupyter_server_config.d/nbgrader.json and I don't see
why jupyter_notebook_config.json should be any different.

* Remove all instances of NotebookApp since the code requires Notebook >= 7
  • Loading branch information
lahwaacz authored Sep 12, 2023
1 parent b9515d8 commit 2ef4451
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 15 deletions.
4 changes: 0 additions & 4 deletions binder/jupyter_config.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
{
"ServerApp": {
"root_dir": "example_course"
},
"NotebookApp": {
"notebook_dir": "example_course",
"root_dir": "example_course"
}
}
10 changes: 0 additions & 10 deletions etc/jupyter/jupyter_notebook_config.json

This file was deleted.

1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ exclude = [

[tool.hatch.build.targets.wheel.shared-data]
"etc/jupyter/jupyter_server_config.d" = "etc/jupyter/jupyter_server_config.d"
"etc/jupyter/jupyter_notebook_config.json" = "etc/jupyter/jupyter_notebook_config.json"
"nbgrader/labextension/static" = "share/jupyter/labextensions/nbgrader/static"
"install.json" = "share/jupyter/labextensions/nbgrader/install.json"
"nbgrader/labextension/package.json" = "share/jupyter/labextensions/nbgrader/package.json"
Expand Down

0 comments on commit 2ef4451

Please sign in to comment.