Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored basic template from 5.x #1431

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Conversation

MSeal
Copy link
Contributor

@MSeal MSeal commented Oct 1, 2020

Extracted the basic template addition from #1387 into an isolated PR. The full.tpl was mapped back to classic instead of lab because it was incorrectly pointing to the newer template in lieu of basic pointing to classic before this.

@MSeal
Copy link
Contributor Author

MSeal commented Oct 1, 2020

Merging to avoid conflicts with next change as it was already reviewed in linked PR

@MSeal MSeal merged commit 0f645ba into jupyter:master Oct 1, 2020
@maartenbreddels
Copy link
Collaborator

LGTM

@ThiefMaster
Copy link

Unlike in 5.6.1, using .template_name = 'basic' (in 5.6.1: .template_file = 'basic') no longer seems to include any CSS. Is this an intentional change from the old behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants