Optimize search to ignore on empty string #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's hard to define what is the expected behaviour here, but I think it's reasonable to assume that searching by an empty string shouldn't impact the result of the query, so I would say that this could enter as a minor version bump. What do you think @jotaviobiondo? |
|
I agree! Maybe document it also as a bug fix? since it changes the current behavior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to optimize a little the query generated when using
Crudry.Query.search/3.But this is possibly a breaking change, since before this change, with an empty
search_term, the rows that have null values for any of the columns specified infieldswere being filtered out. With this PR, the rows with null values will be returned too.What do you guys think, should we proceed with this change?