Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FileFormats.CBF] write VectorOfVariables constraints in VAR block #2478

Merged
merged 2 commits into from
Apr 14, 2024

Conversation

odow
Copy link
Member

@odow odow commented Apr 12, 2024

Part of #2457

@odow odow requested a review from blegat April 12, 2024 05:09
@blegat
Copy link
Member

blegat commented Apr 12, 2024

If the PSD cone is given, do we error ?

@odow
Copy link
Member Author

odow commented Apr 12, 2024

No change to PSD. There's still written as affine cones

@blegat
Copy link
Member

blegat commented Apr 13, 2024

No change to PSD. There's still written as affine cones

Ah that's the current behavior. So it goes through the scalarize bridge ?
So at the moment, conic variables are scalarized and PSD variables are ignored ?

@odow
Copy link
Member Author

odow commented Apr 14, 2024

Before this PR, the model is written out as:

min c' x
Ax - b in K
x free

All VectorOfVariables constraints are accepted (no bridging) but are written as affine constraints.

After this PR, things are written as:

min c' x
Ax - b in K
x in some cones but not all

VectorOfVariables in Exponential, DualExponential, and PositiveSemidefiniteConeTriangle are still supported, but they are written as affine constraints.

@odow
Copy link
Member Author

odow commented Apr 14, 2024

Merging as an improvement for now. I'll look at doing EXP and PSD variables in a separate PR.

@odow odow merged commit 89be884 into master Apr 14, 2024
14 checks passed
@odow odow deleted the od/write-variable-K branch April 14, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants