[Bridges] error on set(_, ::ConstraintSet with variable and constraint bridges

[odow]

Revisiting #2464 for another take at #2452.

This time it definitely fixes the original MWE:

(clarabel) pkg> st
Status `/private/tmp/clarabel/Project.toml`
  [61c947e1] Clarabel v0.7.1
  [4076af6c] JuMP v1.21.0
  [b8f27783] MathOptInterface v1.27.1 `~/.julia/dev/MathOptInterface`

julia> model = Model(Clarabel.Optimizer)
A JuMP Model
Feasibility problem with:
Variables: 0
Model mode: AUTOMATIC
CachingOptimizer state: EMPTY_OPTIMIZER
Solver name: Clarabel

julia> set_silent(model)

julia> @variable(model, x >= 1)
x

julia> @constraint(model, c, 2x == 3)
c : 2 x = 3

julia> optimize!(model)

julia> y = value(x)
1.4999999999999996

julia> b = normalized_rhs(c)
3.0

julia> set_normalized_rhs(c, b)

julia> optimize!(model)

julia> value(x)
1.4999999999999996

MathOptInterface.jl/src/Bridges/Constraint/bridges/vectorize.jl

Lines 221 to 225 in 009004c

	MOI.modify(
	model,
	bridge.vector_constraint,
	MOI.VectorConstantChange([-bridge.set_constant]),
	)

calls

MathOptInterface.jl/src/Bridges/bridge_optimizer.jl

Lines 2044 to 2050 in 009004c

	function MOI.modify(
	b::AbstractBridgeOptimizer,
	ci::MOI.ConstraintIndex,
	change::MOI.AbstractFunctionModification,
	)
	if is_bridged(b, change)
	modify_bridged_change(b, ci, change)

which calls

MathOptInterface.jl/src/Bridges/bridge_optimizer.jl

Lines 1992 to 2003 in 009004c

	function modify_bridged_change(
	b::AbstractBridgeOptimizer,
	ci_or_obj,
	change::Union{MOI.ScalarConstantChange,MOI.VectorConstantChange},
	)
	bridged_func = _bridged_function(b, ci_or_obj)
	unbridged_func = _unbridged_function(b, ci_or_obj)
	bridged_const =
	MOI.constant(bridged_func) + change.new_constant -
	MOI.constant(unbridged_func)
	bridged_change = _constant_change(bridged_const)
	_modify_bridged_function(b, ci_or_obj, bridged_change)

but the issue is that we can't tell whether we're modifying from the user's perspective, or whether we're modifying the inner constraint.

I'm guessing we need some call_in_context, but I got confused, so I decided it's simpler just to punt for now and fix the correctness issue.

[odow]

https://github.com/jump-dev/MathOptInterface.jl/actions/runs/8610208951

[odow]

All ticks green