Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for MOI.AbsoluteGapTolerance and MOI.RelativeGapTolerance #219

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Add support for MOI.AbsoluteGapTolerance and MOI.RelativeGapTolerance #219

merged 2 commits into from
Sep 7, 2023

Conversation

hannes-uppman
Copy link
Contributor

Closes #218

@odow
Copy link
Member

odow commented Sep 7, 2023

Thanks! I just tweaked things slightly to use multiple dispatch instead of the if value === nothing.

@codecov
Copy link

codecov bot commented Sep 7, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.17% 🎉

Comparison is base (537445c) 86.50% compared to head (a1ab5ea) 87.67%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
+ Coverage   86.50%   87.67%   +1.17%     
==========================================
  Files           2        2              
  Lines         326      349      +23     
==========================================
+ Hits          282      306      +24     
+ Misses         44       43       -1
Files Changed Coverage Δ
src/MOI_wrapper/MOI_wrapper.jl 87.86% <100.00%> (+0.84%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

odow
odow approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Segfault on Mac is unrelated.

@odow odow merged commit f495d97 into jump-dev:master Sep 7, 2023
9 of 10 checks passed
@hannes-uppman hannes-uppman deleted the gap branch September 8, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odow odow odow approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support MOI.AbsoluteGapTolerance and MOI.RelativeGapTolerance
2 participants
@hannes-uppman @odow