Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect conversion in Cbc_loadProblem #184

Merged
merged 9 commits into from
Dec 1, 2021
Merged

Fix incorrect conversion in Cbc_loadProblem #184

merged 9 commits into from
Dec 1, 2021

Conversation

odow
Copy link
Member

@odow odow commented Nov 10, 2021

Potential fix for #183

@odow

This comment has been minimized.

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #184 (f6289a0) into master (1b24948) will increase coverage by 6.83%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
+ Coverage   54.61%   61.44%   +6.83%     
==========================================
  Files           3        3              
  Lines         542      581      +39     
==========================================
+ Hits          296      357      +61     
+ Misses        246      224      -22     
Impacted Files Coverage Δ
src/MOI_wrapper/MOI_wrapper.jl 87.71% <100.00%> (+6.87%) ⬆️
src/gen/libcbc_api.jl 21.92% <0.00%> (+9.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b24948...f6289a0. Read the comment docs.

@odow
Copy link
Member Author

odow commented Nov 10, 2021

@DrChainsaw can you try this branch? Looks like we had a cheeky off-by-1 error. I wonder if this was the cause of our troubles in #151

@DrChainsaw
Copy link

This seemed to have done the trick!

I could run testsos 100 times in a loop and the testcase which exposed the issue in NaiveNASflux also passes with the branch.

@odow odow merged commit 0bb8cb5 into master Dec 1, 2021
@odow odow deleted the odow-patch-1 branch December 1, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants