Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove between Binding linkages #248

Merged
merged 3 commits into from
Jan 26, 2021
Merged

Remove between Binding linkages #248

merged 3 commits into from
Jan 26, 2021

Conversation

ZacLN
Copy link
Contributor

@ZacLN ZacLN commented Jan 25, 2021

Removes the prev and next field from Binding and replaces them with an approach where only the initial binding for a function/datatype is used - all subsequent methods are stored within that initial binding (e.g. a pseudo method table). Intended to solve stackoverflow errors when iterating through function methods.

This is ready - bugs will follow but should be relatively easy to squash and may solve one of our most persistent bugs. Interface change so requires ver bump

ZacLN added 2 commits January 25, 2021 19:38

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
@ZacLN ZacLN marked this pull request as ready for review January 25, 2021 22:50
@ZacLN ZacLN self-assigned this Jan 25, 2021
@ZacLN ZacLN added this to the Next Patch milestone Jan 25, 2021
Copy link
Member

@davidanthoff davidanthoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a cursory (very!) review. Agreed on lets merge this and then fix bugs as they come up.

@davidanthoff davidanthoff merged commit ea21364 into master Jan 26, 2021
@davidanthoff davidanthoff deleted the dropprevnext branch January 26, 2021 00:11
@oppo-source oppo-source removed the request for review from a team April 16, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants