Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't duplicate completions #962

Merged
merged 2 commits into from
Jul 17, 2021
Merged

Don't duplicate completions #962

merged 2 commits into from
Jul 17, 2021

Conversation

ZacLN
Copy link
Contributor

@ZacLN ZacLN commented Jul 13, 2021 •
edited
Loading

Fixes an issue whereby completion items were duplicated. This prevents the addition of explicit imports for already imported symbols (e.g. Core symbols that are exported by Base).

For every PR, please check the following:

@ZacLN ZacLN requested a review from a team July 13, 2021 16:05
@davidanthoff davidanthoff merged commit 2d941ac into master Jul 17, 2021
@davidanthoff davidanthoff deleted the import-comps branch July 17, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfitzseb pfitzseb pfitzseb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZacLN @pfitzseb @davidanthoff