Use file URIs for MD links in hover popups for Sublime too #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LSP client for Sublime Text doesn't support the filepath:line format as it is used for Markdown link destinations in hover results (anymore), but can handle file URIs with a `#line` suffix, like they are already used for VS Code. This change allows to open links to other files in hover popups in Sublime Text too.
|
Cool, thanks! |
pfitzseb
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LSP client for Sublime Text doesn't support (anymore) the filepath:line format as it is used for Markdown link destinations to other files in hover results. There is some special casing by the server for VS Code to use a file URIs with a
#linesuffix, and those can be handled by the Sublime Text client (on the latestmainbranch) too, so this change would restore the functionality to open file links there. The name used inclientInfois "Sublime Text LSP".I haven't checked if the file URI format is supported by the other clients for Emacs/vim too, but perhaps this special check for VSCode (and now Sublime) could even be removed completely in favor of always using file URIs instead.