better shutdown handling #907

pfitzseb · 2021-03-10T11:17:39Z

For every PR, please check the following:

End-user documentation check. If this PR requires end-user documentation in the Julia VS Code extension docs, please add that at https://github.com/julia-vscode/docs.
Changelog mention. If this PR should be mentioned in the CHANGELOG for the Julia VS Code extension, please open a PR against https://github.com/julia-vscode/julia-vscode/blob/master/CHANGELOG.md with those changes.

davidanthoff

So I'm not really convinced this is the right way to handle this, see my comments inline.

src/languageserverinstance.jl

pfitzseb · 2021-03-12T11:43:44Z

This should be fairly uncontroversial as-is, right?

Would like to get this in asap because I've started collecting zombies too and testing this requires a bit of time, I think

better shutdown handling

6733b8c

pfitzseb added the enhancement label Mar 10, 2021

pfitzseb mentioned this pull request Mar 10, 2021

Better shutdown handling julia-vscode/julia-vscode#2014

Closed

2 tasks

davidanthoff requested changes Mar 10, 2021

View reviewed changes

src/languageserverinstance.jl Outdated Show resolved Hide resolved

src/languageserverinstance.jl Outdated Show resolved Hide resolved

no isopen

3509797

pfitzseb requested a review from davidanthoff March 11, 2021 18:48

davidanthoff approved these changes Mar 12, 2021

View reviewed changes

davidanthoff merged commit 6d504b8 into master Mar 12, 2021

davidanthoff deleted the sp/shutdown branch March 12, 2021 17:32

oppo-source removed the request for review from a team April 16, 2021 07:35

Provide feedback