-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completions for unexported symbols #892
Conversation
Almost. What I had in mind would make this work for all symbols, not only unexported ones (which may or may not be a good idea :P). Basically to counteract people using This feels pretty good though, so I think we could get this in as-is (although it still needs a setting in the UI, right?). |
That feels a bit much for me personally but no reason to not include it as an option. Would we also want a project level action that applies that style retrospectively? Agree on merging this as is for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a review from @pfitzseb and a merge conflict resolution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, let's get this in!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests fail. Do we maybe need a tag for some dependency for this to work?
@pfitzseb, as we discussed the other day - is this what you meant?
EDIT - a description
Completions are now provided for symbols that are not exported by modules in the current namespace. These are only triggered when the partial string has length > 3. Two modes are provided where:
var
from some modulem
results in the automatic inclusion of a using statementusing m: var
. This is included at the start of the current root tree and will be attached to existingusing m:...
if possible; orm.var
)