-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable linting in test folders #776
Conversation
src/utilities.jl
Outdated
if VERSION < v"1.1" | ||
return false | ||
else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you just forgot to remove this check ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep!
Does this disable all linting or only "global" linting? It would be nice to still have some for of checking in local files, for example. |
I don't understand what you mean. This disables linting for files located within a "test" sub-directory of a folder that is a Julia package folder if that makes it clearer? |
Right, but it would be cool if it didn't disable all linting -- some features are local to the current file (and maybe |
Is it easy to do "basic lintings" (i.e. syntax-errors and such, those could be done by per-expression or per-file) separately from "more complex linting" (like warning on undef name, which would be done by per-file or per-package level) ? |
This now disables lint checks that are dependent on having an accurate representation of the package environment. Not a particularly elegant approach, I need to start categorising LintCodes. |
Nice, this is exactly what I had in mind! Can always fix up the implementation at a later point |
No description provided.