Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix FormatOptions inconsistency #756

Merged
merged 2 commits into from
Jun 15, 2020
Merged

fix FormatOptions inconsistency #756

merged 2 commits into from
Jun 15, 2020

Conversation

ZacLN
Copy link
Contributor

@ZacLN ZacLN commented Jun 14, 2020

The wrong configuration name was being requested, kwspacing -> kwarg.

Mentioned in #753

@ZacLN ZacLN added the bug label Jun 14, 2020
@ZacLN ZacLN added this to the Next extension patch release milestone Jun 14, 2020
@ZacLN ZacLN self-assigned this Jun 14, 2020
@davidanthoff
Copy link
Member

Haha, I just opened PRs against DocumentFormat and julia-vscode that uses kwspacing for this.

kwspacing seems a more descriptive name for the config setting, right, so should we go with that?

@ZacLN
Copy link
Contributor Author

ZacLN commented Jun 14, 2020

Happy either way (I was clearly in two minds at the time!). Using kwspacing will require a PR against package.json in julia-vscode

@davidanthoff
Copy link
Member

You decide, this is more your part of the codebase :) The PRs that are needed for kwspacing are also open, you can just either merge those two, or this one here.

@ZacLN ZacLN merged commit 3cd7214 into master Jun 15, 2020
@ZacLN ZacLN deleted the fixdocconfig branch June 15, 2020 20:36
@oppo-source oppo-source removed the request for review from a team April 16, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants