Add escaping when comparing/hashing URI2 #702
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of discussion in #699 PR, that allows comparing URIs that were created using different encoding schemes.
Basically what it does is it escapes URI to bring it to the same encoding scheme as in vscode-uri.
This allows for following comparisons:
It escapes only file URI, since I'm not sure if escaping is needed in other cases.
Note: It still needs to be checked if "VS Code internally also treats two strings that stand for the same URI but use different encoding patterns as equal or not", so this may be considered as WIP.