Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add handler function for julia/help request #377

Closed
wants to merge 2 commits into from
Closed

Conversation

ZacLN
Copy link
Contributor

@ZacLN ZacLN commented Jul 30, 2019

@davidanthoff davidanthoff added this to the Backlog milestone Dec 14, 2019
@aviatesk
Copy link
Member

aviatesk commented Jun 6, 2020

The pain point of this approach is that we can't get documentation for user code.
What do you think about using our REPL session for this ? I have a working implementation that works for any user package code as well as usual script.

@davidanthoff
Copy link
Member

I do think we should be able to get the documentation for user code in the LS process because we have a live parsed representation of every file in the workspace here, and that should include any user docs.

But, I don't know how :) Maybe looking at https://github.com/julia-vscode/LanguageServer.jl/blob/master/src/requests/hover.jl might clarify it? Otherwise, @ZacLN would know :)

@ZacLN
Copy link
Contributor Author

ZacLN commented Jun 8, 2020

You can pull explicit documentation from the CST easily as in David's link above

@aviatesk aviatesk mentioned this pull request Jun 9, 2020
@pfitzseb pfitzseb closed this Apr 29, 2022
@davidanthoff davidanthoff deleted the ZacLN-patch-1 branch May 2, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants