fix stopline #1228
Merged
fix stopline #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Possible to test this? See #1190 for some inspiration on how to test formatting. |
|
I don' t have idea why end index could overflow, so don' t know how to test. I only have very long files that cannot be shared that seems to trigger this. Can we merge it so it doesn' t crash the LSP frequently for now. And when someone comes up with some short example file to add to the test or fix the underlying issue causing the overflow. |
|
What commands do you use to trigger the formatting? I have never seen this crash so I am curious what the difference is. |
|
Just |
pfitzseb
approved these changes
Jul 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1223,#1227.