Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add action for adding a docstring snippet. #1084

Merged
merged 2 commits into from
May 20, 2022
Merged

Add action for adding a docstring snippet. #1084

merged 2 commits into from
May 20, 2022

Conversation

fredrikekre
Copy link
Member

No description provided.

pfitzseb
pfitzseb previously approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@pfitzseb pfitzseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do you think it'd make sense to have the action create or update the docstring (update the first line only, if necessary)?

@fredrikekre
Copy link
Member Author

You mean to add the signature part if it is missing?

@pfitzseb
Copy link
Member

That or if it's outdated.

@fredrikekre
Copy link
Member Author

I made it into two different ones.

@fredrikekre fredrikekre reopened this May 18, 2022
@fredrikekre fredrikekre force-pushed the fe/docstring branch 2 times, most recently from 8a33c9e to eddd331 Compare May 18, 2022 14:54
@fredrikekre fredrikekre requested a review from pfitzseb May 20, 2022 10:44
@fredrikekre fredrikekre merged commit 018d838 into master May 20, 2022
@fredrikekre fredrikekre deleted the fe/docstring branch May 20, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfitzseb pfitzseb pfitzseb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredrikekre @pfitzseb