-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] fix broken links #3841
[Docs] fix broken links #3841
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3841 +/- ##
==========================================
- Coverage 97.67% 97.58% -0.09%
==========================================
Files 136 133 -3
Lines 9969 9957 -12
Branches 3693 3693
==========================================
- Hits 9737 9717 -20
- Misses 232 240 +8 ☔ View full report in Codecov by Sentry. |
sigh, facebook broke a bunch of links. there's a dozen other facebook.github.io links in the repo; can you fix all of them? |
Yeah weird that they did not migrate their blog posts. I fixed other links. I was able to replace one with the newer docs. |
Sorry for the wait, I kinda forgotten this 😅 Should be all good now |
@bastiendmt … why did you break the PR? |
I had it under control, but now it's unrecoverable. |
@bastiendmt Please don't do anything, ESPECIALLY please don't create a new PR. |
Sorry, I tired to rebase but I couldn't do it properly, the action told me that some conflict were present |
Yes, that's expected because i'm in the middle of fixing master. |
Alright, I didn't knew that, let me know if you want me to re-open this PR later on. Sorry again |
It's impossible to reopen it once you've closed it by force-pushing "nothing" to it. In this case I'll land the commit manually. |
Landed in 958954d. |
Hi !
The link in
no-is-mounted
is broken.I was able to find the article in the legacy docs.
This PR fixes the link