Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] fix broken links #3841

Closed
wants to merge 0 commits into from
Closed

Conversation

bastiendmt
Copy link
Contributor

Hi !

The link in no-is-mounted is broken.

I was able to find the article in the legacy docs.

This PR fixes the link

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.58%. Comparing base (63aceff) to head (217185b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3841      +/-   ##
==========================================
- Coverage   97.67%   97.58%   -0.09%     
==========================================
  Files         136      133       -3     
  Lines        9969     9957      -12     
  Branches     3693     3693              
==========================================
- Hits         9737     9717      -20     
- Misses        232      240       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ljharb
Copy link
Member

ljharb commented Oct 16, 2024

sigh, facebook broke a bunch of links.

there's a dozen other facebook.github.io links in the repo; can you fix all of them?

@bastiendmt
Copy link
Contributor Author

sigh, facebook broke a bunch of links.

there's a dozen other facebook.github.io links in the repo; can you fix all of them?

Yeah weird that they did not migrate their blog posts.

I fixed other links. I was able to replace one with the newer docs.
Also one link is missing even in the legacy docs so I completely removed the link

@bastiendmt
Copy link
Contributor Author

Sorry for the wait, I kinda forgotten this 😅 Should be all good now

@ljharb ljharb changed the title fix broken link in no-is-mounted.md [Docs] fix broken links Dec 9, 2024
@bastiendmt bastiendmt closed this Dec 9, 2024
@ljharb
Copy link
Member

ljharb commented Dec 9, 2024

@bastiendmt … why did you break the PR?

@ljharb
Copy link
Member

ljharb commented Dec 9, 2024

I had it under control, but now it's unrecoverable.

@ljharb
Copy link
Member

ljharb commented Dec 9, 2024

@bastiendmt Please don't do anything, ESPECIALLY please don't create a new PR.

@bastiendmt
Copy link
Contributor Author

I had it under control, but now it's unrecoverable.

Sorry, I tired to rebase but I couldn't do it properly, the action told me that some conflict were present

@ljharb
Copy link
Member

ljharb commented Dec 9, 2024

Yes, that's expected because i'm in the middle of fixing master.

@bastiendmt
Copy link
Contributor Author

Yes, that's expected because i'm in the middle of fixing master.

Alright, I didn't knew that, let me know if you want me to re-open this PR later on. Sorry again

@ljharb
Copy link
Member

ljharb commented Dec 9, 2024

It's impossible to reopen it once you've closed it by force-pushing "nothing" to it. In this case I'll land the commit manually.

@ljharb
Copy link
Member

ljharb commented Dec 9, 2024

Landed in 958954d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants