Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New] jsx-handler-names: support ignoring component names #3772

Merged
merged 1 commit into from
Jul 15, 2024
Merged

[New] jsx-handler-names: support ignoring component names #3772

merged 1 commit into from
Jul 15, 2024

Conversation

akulsr0
Copy link
Contributor

@akulsr0 akulsr0 commented Jun 21, 2024

Closes #3722

@codecov Codecov
Copy link

codecov bot commented Jun 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.63%. Comparing base (b747450) to head (1625b1a).

❗ Current head 1625b1a differs from pull request most recent head 58c9063

Please upload reports for the commit 58c9063 to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3772      +/-   ##
==========================================
+ Coverage   97.51%   97.63%   +0.11%     
==========================================
  Files         134      134              
  Lines        9625     9631       +6     
  Branches     3494     3496       +2     
==========================================
+ Hits         9386     9403      +17     
+ Misses        239      228      -11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ljharb ljharb changed the title [Fix] jsx-handler-names: support ignoring component names [New] jsx-handler-names: support ignoring component names Jun 25, 2024
@ljharb ljharb force-pushed the master branch 2 times, most recently from 380e32c to 51d342b Compare July 4, 2024 15:25
@akulsr0
Copy link
Contributor Author

akulsr0 commented Jul 11, 2024

Bump up

ljharb
ljharb requested changes Jul 11, 2024
View reviewed changes
docs/rules/jsx-handler-names.md Outdated Show resolved Hide resolved
@akulsr0 akulsr0 force-pushed the akul/fix-issue#3722 branch from 2a62ac6 to b827d6b Compare July 12, 2024 14:54
ljharb
ljharb approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks. I'm going to hold off landing semver-minors for a little bit, but the next one will include this PR.

tests/lib/rules/jsx-handler-names.js Outdated Show resolved Hide resolved
tests/lib/rules/jsx-handler-names.js Outdated Show resolved Hide resolved
@ljharb ljharb force-pushed the akul/fix-issue#3722 branch from bd2e2e3 to 6a83d67 Compare July 15, 2024 06:20
@ljharb ljharb merged commit 6a83d67 into jsx-eslint:master Jul 15, 2024
343 checks passed
@alhugot-azpn alhugot-azpn mentioned this pull request Aug 10, 2024
Merged
@zdr4k zdr4k mentioned this pull request Aug 10, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Aug 10, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Aug 10, 2024
Open
This was referenced Aug 10, 2024
Open
Open
Open
This was referenced Aug 10, 2024
Open
Open
@patooworld patooworld mentioned this pull request Aug 10, 2024
Open
This was referenced Aug 10, 2024
Open
Open
@Exkaleburx Exkaleburx mentioned this pull request Aug 10, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Aug 10, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Aug 11, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Aug 11, 2024
Open
@richyhoopd richyhoopd mentioned this pull request Aug 11, 2024
Open
@alhugot-azpn alhugot-azpn mentioned this pull request Aug 12, 2024
Closed
@Exkaleburx Exkaleburx mentioned this pull request Oct 4, 2024
Open
@CASABECI CASABECI mentioned this pull request Oct 6, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Oct 6, 2024
Open
@Sarrac3873 Sarrac3873 mentioned this pull request Oct 16, 2024
Open
@zdr4k zdr4k mentioned this pull request Oct 20, 2024
Open
This was referenced Oct 22, 2024
Open
Open
Open
@Loonz206 Loonz206 mentioned this pull request Oct 23, 2024
Open
This was referenced Oct 23, 2024
Open
Open
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Oct 25, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 26, 2024
Open
@richyhoopd richyhoopd mentioned this pull request Oct 26, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Oct 26, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Oct 26, 2024
Open
@Vishesh7797 Vishesh7797 mentioned this pull request Oct 27, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 27, 2024
Open
@zdr4k zdr4k mentioned this pull request Oct 27, 2024
Open
@DadonStyle DadonStyle mentioned this pull request Oct 27, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Oct 28, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Oct 31, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Nov 2, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Nov 2, 2024
Open
@DadonStyle DadonStyle mentioned this pull request Nov 3, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Nov 7, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Nov 7, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Nov 11, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jsx-handler-names support skipping prop naming checks
2 participants
@akulsr0 @ljharb