[Perf] component detection: improve performance by avoiding traversing parents unnecessarily #3459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g parents unnecessarily
golopot
commented
Oct 11, 2022
Comment on lines
464
to
465
| return <Text>{this.props.foo}</Text>; | ||
| } |
There was a problem hiding this comment.
This should not be reported because React.createClass is not the correct pragma here. So there should be no component detected thus no report.
Codecov Report
@@ Coverage Diff @@
## master #3459 +/- ##
==========================================
- Coverage 97.58% 97.54% -0.05%
==========================================
Files 127 127
Lines 9068 9066 -2
Branches 3308 3307 -1
==========================================
- Hits 8849 8843 -6
- Misses 219 223 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
golopot
commented
Oct 11, 2022
| @@ -871,7 +877,7 @@ function componentRule(rule, context) { | |||
| return; | |||
| } | |||
|
|
|||
| node = utils.getParentComponent(); | |||
There was a problem hiding this comment.
No need to find parent components here.
ljharb
force-pushed
the
perf-no-getParent
branch
from
d6ece7f to
bf59919
Compare
ljharb
added
the
hacktoberfest-accepted
ljharb
pushed a commit
to ljharb/eslint-plugin-react
that referenced
this pull request
Nov 18, 2022
…g parents unnecessarily (jsx-eslint#3459)
1 task
This was referenced May 24, 2024
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes an
eslint .withplugin:react/allenabled run about 13% faster.