[react/jsx-curly-brace-presence] False positive on jsx passed to prop

[bhollis]

return (
  <CollapsibleTitle
    extra={<span className="activity-type">{activity.type}</span>}
  />
);

"react/jsx-curly-brace-presence": ["error", "never"],

After upgrading from 7.28.0 to 7.29.2, this highlights that the extra prop should not have curly braces, when it is not possible for them to be omitted.

[ljharb]

It is in fact possible for them to be omitted; that's what the propElementValues config (added recently) is for.

however, using just "never" should result in propElementValues being set to "ignore", so you shouldn't see a warning here.

[bhollis]

Ah, interesting. It's certainly not allowed by TypeScript.

[ljharb]

Yep, the TS eslint parser doesn't support it, but eslint, babel, and the jsx spec do.

to be fair, I only recently learned of its existence, and i think it's horrifying that jsx allows them to be omitted there :-)