feat: supported scoped package and replace class #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the original maintainer of jsonresume-theme-class no longer wishes to maintain the project, I've forked it so the jsonresume namespace on GitHub so we can continue maintaining it.
I've already pushed all my updates, got it working with JSON Resume Schema 1.0.0, and even published it to NPM.
Now I'd like it to be listed on the website, but one annoyance is that how we've done this, we can't import scoped packages.
I think we should change the behavior here so that we check the package name in full, i.e.
@jsonresume/jsonresume-theme-class
instead of justclass
.My proposed implementation will fall back to the original slug/append approach you had before where
elegant
will just havejsonresume-theme-
prepended to it if noelegant
theme exists.This still requires themes to have the term
theme
in the name, which I don't think is ideal, but we can review that separately.I have not tested this yet.