Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supported scoped package and replace class #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SethFalco
Copy link
Member

Since the original maintainer of jsonresume-theme-class no longer wishes to maintain the project, I've forked it so the jsonresume namespace on GitHub so we can continue maintaining it.

I've already pushed all my updates, got it working with JSON Resume Schema 1.0.0, and even published it to NPM.

Now I'd like it to be listed on the website, but one annoyance is that how we've done this, we can't import scoped packages.

I think we should change the behavior here so that we check the package name in full, i.e. @jsonresume/jsonresume-theme-class instead of just class.

My proposed implementation will fall back to the original slug/append approach you had before where elegant will just have jsonresume-theme- prepended to it if no elegant theme exists.

This still requires themes to have the term theme in the name, which I don't think is ideal, but we can review that separately.


I have not tested this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant