Binary/Octal/Hexadecimal numbers #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing and reopening to see if that triggers Travis |
|
Looks good, thanks for the contribution @bigbug 👍 |
mattbaileyuk
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation the $number() function does not allow the conversion of binary, octal or hexadecimal numbers. This PR changes that.
A regex is used to find such numbers with a given prefix (
0xfor hexadecimal,0ofor octal,0bfor binary). If a valid Number is found, JavaScript's built-in functionNumber()is used to convert the string to a number.Tests and Documentation have been adapted.
Signed-off-by: Markus Gutbrod [email protected]