Avoid removing files not ended in .rb #452
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was not able to pass specs, neither in travis nor my pc. Force-pushed to try again, but it was unsuccessful |
| @@ -108,7 +108,9 @@ def define_compiled_task | |||
| task "compiled" do | |||
| jar.compile(config) | |||
| task @name do | |||
| rm_f config.compiled_ruby_files.map {|f| f.sub(/\.rb$/, '.class') } | |||
| extensions = config.compiled_ruby_files&.map { |f| File.extname(f) }&.uniq || ['.rb'] | |||
| regex_extensions = extensions.map { |extension| extension.sub('.', '\.') }.join('|') | |||
There was a problem hiding this comment.
RegExp.union is pretty great:
extensions = Pathname.glob("config/**/*").map(&:extname).uniq
# [".pem", ".rb", ".yml", ".ignore", "", ".md", ".markdown", ".json"]
Regexp.union(extensions)
# /\.pem|\.rb|\.yml|\.ignore||\.md|\.markdown|\.json/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the option
compiled_ruby_filesis personalized to use different extensions, for instance,.rakefiles. They are removed each time warble is called.Problem was in
lib/warbler/task.rbwhere every file not ended in.rbwere being removed.