feat(pydantic): allow pydantic model instances as defaults (#64)

[dada-engineer]

This allows pydantic BaseModels as default values.

Fixes #64

[dada-engineer]

linting fails because black and flake8 have a different opinion on how

class PyType(str):
    ...

should be formatted.

black now wants to do:

class PyType(str): ...

But flake8 then complains that there are multiple statements on one line.

[faph]

So this flake8 vs black conflict. Is there a way that we can configure either of the tools to handle this OK?

[dada-engineer]

So this flake8 vs black conflict. Is there a way that we can configure either of the tools to handle this OK?

I guess this comment makes sense: psf/black#4213 (comment)

TLDR;
deactivate flake8 rule for stuff that is handled by formatter.

[faph]

Got you, so that should be a change in .flake8 file?

[dada-engineer]

Looks like it, should I add this here?

[dada-engineer]

Had some issue with mypy as well, fixed in same commit.

[faph]

Love it!

Are we good to merge?

[dada-engineer]

I am okay with it, but since I removed it lists of pydantic objects will not yet work. I'll open a new issue for this or a second PR later.

[faph]

Understood. Many thanks for this contribution.

[koenlek]

Thanks for making this fix! Unfortunately, I'm stuck on py-avro-schema v2 (and upgrading is going to be very hard I'm afraid). Any suggestions on how I could try and patch v2 or work around this issue?

I tried patching the make_default logic into v2, but it doesn't seem to work unfortunately...

Any hints would be highly appreciated 🙏

[koenlek]

NVM. Gotten it to work and posted it for others here: #64 (comment)