Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and fix flags #42

Closed
wants to merge 7 commits into from
Closed

Add and fix flags #42

wants to merge 7 commits into from

Conversation

not-my-profile
Copy link
Contributor

No description provided.

@jplatte
Copy link
Owner

jplatte commented Dec 10, 2021 •
edited
Loading

The version of at least the LinkedList::new const feature was correct before. The attribute in the Rust standard library is incorrect. Here's the PR: rust-lang/rust#63684 which was merged way after 1.32's release. Would be nice to include the PR number in the feature though (and of course fix the attribute upstream).

How did you find all of these by the way?

@not-my-profile
Add more flags
42fcb45 
The flags were found by running the following command in the Rust repo:

git grep -hEo '(un)?stable\(feature =.+\)' library/ | grep -v 'issue = "none"' | sort  | uniq
@not-my-profile
Add impl_pr_id for const_linkedlist_new
d844896
@not-my-profile
Copy link
Contributor Author

not-my-profile commented Dec 10, 2021 •
edited
Loading

Ah, nice catch! I updated the PR accordingly and opened rust-lang/rust#91755 upstream.

I added the command I used to the commit message (please don't squash the commits^^).

@jplatte
Copy link
Owner

jplatte commented Dec 11, 2021

I've merged all of the commits except for the change of version for the ManuallyDrop features. Do you have a PR reference for that?

@not-my-profile
Copy link
Contributor Author

Thank you! Right ... my bad. I thought that the since attributes in the source code were accurate. I just tested by installing Rust 1.31.0 and 1.32.0 with rustup and the ManuallyDrop functions indeed were stabilized in 1.32.0 ... I'll send a patch upstream.

@not-my-profile not-my-profile deleted the flags branch December 11, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@not-my-profile @jplatte