Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix walkthrough scenario #1

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Fix walkthrough scenario #1

merged 1 commit into from
Aug 21, 2018

Conversation

mszostok
Copy link
Contributor

Description

Changes proposed in this pull request:

Fix minor bugs in the walkthrough scenario by:

kustomize build config/default | kubectl apply -f -
Error: loadResMapFromBasesAndResources: rawResources failed to read Resources: Load from path ../rbac/*.yaml failed: open /Users/i331808/workspace/go/src/github.com/jpeeler/podpreset-crd/config/rbac/*.yaml: no such file or directory
  • fixing missing dependencies in vendor
    previous error:
make docker-build-webhook

CGO_ENABLED=0 GOOS=linux go build -o ./webhook/webhook ./webhook/
webhook/main.go:31:2: cannot find package "github.com/mattbaird/jsonpatch" in any of:
	/Users/i331808/workspace/go/src/github.com/jpeeler/podpreset-crd/vendor/github.com/mattbaird/jsonpatch (vendor tree)
	/usr/local/Cellar/go/1.10.2/libexec/src/github.com/mattbaird/jsonpatch (from $GOROOT)
	/Users/i331808/workspace/go/src/github.com/mattbaird/jsonpatch (from $GOPATH)
make: *** [docker-build-webhook] Error 1
  • fixing sed command to works also on OS X system
    previous error:
updating kustomize image patch file for manager resource
sed -i 's@image: .*@image: '"docker.io/service-catalog/podpreset-controller:latest"'@' ./config/default/manager_image_patch.yaml
sed: 1: "./config/default/manage ...": invalid command code .
make: *** [docker-build] Error 1

@jpeeler jpeeler merged commit f726860 into jpeeler:master Aug 21, 2018
@jpeeler
Copy link
Owner

jpeeler commented Aug 21, 2018

Thanks for the contribution and validating the implementation in this repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants