Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1308

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update dependencies #1308

wants to merge 3 commits into from

Conversation

LMG
Copy link
Collaborator

@LMG LMG commented Jan 10, 2024

No description provided.

@LMG LMG force-pushed the update_rust branch 2 times, most recently from 056b0f8 to 07e23e9 Compare January 10, 2024 07:37
Upgrade to rust 1.75
Run cargo update
Run cargo upgrade
@vlad-ivanov-name
Copy link
Collaborator

I think it’s maybe worth it to create a file called hyper_util or something and move some of the code there. For example a function to create an empty body would be called make_empty_body because Full(Bytes::new()) is not exactly semantically meaningful and easy to read

Copy link
Member

@christian-schilling christian-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved it, but need to take it back. Disabling LFS will probably break some users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants