Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esm-env warning #507

Closed
bdbvb opened this issue Dec 10, 2024 · 1 comment
Closed

esm-env warning #507

bdbvb opened this issue Dec 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@bdbvb
Copy link

bdbvb commented Dec 10, 2024

I'm seeing the following console warning when loading my app that uses vanilla-jsoneditor (2.3.2), bundled using Vite.

If bundling, conditions should include development or production. If not bundling, conditions or NODE_ENV should include development or production. See https://www.npmjs.com/package/esm-env for tips on setting conditions in popular bundlers and runtimes.

That warning points to esm-env, which is used by svelte, which is used by vanilla-jsoneditor.

Any thoughts on how I can address that warning?

Thanks!

@josdejong
Copy link
Owner

Yeah, I noticed it myself too, after updating the vite and svelte dependencies. I had to add some extra configuration in the Rollup config that creates the vanilla bundle.

This issue has been fixed now in v2.2.3.

@josdejong josdejong added the bug Something isn't working label Dec 11, 2024
@bdbvb bdbvb closed this as completed Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants