-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialization support #79
Conversation
Unfurtunately, a phantom `HashMapVisitor` struct had to be created.
Updated error message on `<HashMapVisitor as Visit>::visit_map` Co-Authored-By: Jon Gjengset <[email protected]>
Fixed typo. Co-Authored-By: Jon Gjengset <[email protected]>
…mentation of `Visit` for `HashMapVisitor`
…S` where `S: Dafult`
…ocating the output by using `HashMap::with_capacity_and_hasher` and `HashMap::with_hasher` instead of `HashMap::default`
I'm not sure what I should do about the Minimum supported Rust version: 1.36.0 thing (which is causing CI to block)... |
Well, it fails because of the use of the |
I see. I didn't know what was causing the block. I'll fix the as soon as I can. |
You can see the build errors by clicking "details" next to the failed test, then "View more details on Azure Pipelines" at the bottom of the shown pane, and then clicking the failing build step in the list on the left. |
My bad, I forgot pass the `--features serde` flag when testing..
Okay, one last question before we merge this: do we want to separate the impls of external traits (like |
Oh, and we should probably add some rudimentary tests here. A round-trip test for each data structure should be sufficient (that is, that |
Makes sense to me. I'll work on that. |
That would be nice. Is there a way I can import a crate only in the context of test though? I'd have to use something like |
I'm not sure I follow? Just add it as a |
Yes, I just don't know how to do that hehe. |
I've pushed a commit to GarkGarcia:master, but I doesn't show up in here for some reason... |
GitHub is having issues :) To add a test dependency, just list it under here: Line 34 in d1f67c2
|
Thanks!
Ohh I see. I found it strange that my commit was rejected a couple of times due to Internal Server Issues. |
All done (?) |
Nice, thank you! |
This is a follow up to #15.
This change is