Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Refactor dipole visualization to invert y-axis when min_freq > max_freq #903

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

samadpls
Copy link
Contributor

Added support for reversed y-axis in plot_tfr_morlet to allow min_freq > max_freq
Fixes #898

@samadpls samadpls force-pushed the fix/y-axis-flip branch 4 times, most recently from 44eabf0 to dca5a42 Compare October 25, 2024 13:49
@samadpls
Copy link
Contributor Author

@gtdang, should I update whats_new.rst for these changes?

@gtdang
Copy link
Collaborator

gtdang commented Oct 25, 2024

Yes, please do. Thanks!

@samadpls
Copy link
Contributor Author

samadpls commented Oct 29, 2024

Thanks! I have updated the what's new file. @asoplata , I appreciate your review on the pull request.

@gtdang gtdang requested a review from asoplata October 30, 2024 14:08
@asoplata
Copy link
Collaborator

Apologies for the radio silence, @samadpls . We've been in emergency hotfix & feature development for several weeks due to needing updates to use in-class and elsewhere, but that should be over now. I have a personal TODO to review all of your PRs / etc. asap :). Inspecting this one now.

@asoplata
Copy link
Collaborator

Unfortunately there is an issue preventing this from working fully on the spectrogram display in the GUI (note that to see the spectrogram on the GUI for the default simulation at all, you have to apply #938 ). In the GUI, if you run the default simulation and generate a default spectrogram, everything works correctly. However, if I change the min and max frequencies such that min > max, no spectrogram is displayed. Simple changes to freqs here https://github.com/jonescompneurolab/hnn-core/blob/master/hnn_core/gui/_viz_manager.py#L304 aren't enough to fix the problem. Will try to investigate more tomorrow.

@asoplata asoplata added the hnn-gui HNN GUI label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hnn-gui HNN GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow reversed y-axis on spectrogram plots
3 participants