Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] GUI tutorial gamma #535

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jasmainak
Copy link
Collaborator

I am volunteering for the gamma tutorial. The diff will look better once #529 is merged

@chenghuzi I need a method to show a particular drive. Do we have that?

@jasmainak jasmainak changed the title GUI tutorial gamma [WIP] GUI tutorial gamma Aug 8, 2022
@jasmainak jasmainak force-pushed the gui_tutorial_gamma branch from a0b60d8 to f2ccf09 Compare August 8, 2022 01:48
@jasmainak jasmainak added the hnn-gui HNN GUI label Aug 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2022

Codecov Report

Merging #535 (558c220) into master (52ee292) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #535      +/-   ##
==========================================
- Coverage   90.24%   90.12%   -0.13%     
==========================================
  Files          20       20              
  Lines        3988     3968      -20     
==========================================
- Hits         3599     3576      -23     
- Misses        389      392       +3     
Impacted Files Coverage Δ
hnn_core/parallel_backends.py 81.49% <0.00%> (-0.83%) ⬇️
hnn_core/cell_response.py 84.00% <0.00%> (-0.54%) ⬇️
hnn_core/extracellular.py 86.69% <0.00%> (-0.26%) ⬇️
hnn_core/cell.py 97.10% <0.00%> (-0.11%) ⬇️
hnn_core/gui/gui.py 84.97% <0.00%> (-0.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jasmainak
Copy link
Collaborator Author

@chenghuzi I need a method to show a particular drive. Do we have that?

@chenghuzi do we have this feature implemented in #543 ? Do you anticipate any other blockers for this tutorial to be finished?

@chenghuzi
Copy link
Collaborator

@chenghuzi I need a method to show a particular drive. Do we have that?

@chenghuzi do we have this feature implemented in #543 ? Do you anticipate any other blockers for this tutorial to be finished?

That's hard. We can turn on the selected_index but since the drive tab is usually very long so setting index to the one we want to see won't help. To do that you need to scroll, but that requires manipulation with javascript.

@jasmainak
Copy link
Collaborator Author

jasmainak commented Aug 29, 2022 via email

@chenghuzi
Copy link
Collaborator

Once we turn legacy_mode False by default we won’t have more than 3 drives in a tutorial. Still need to scroll?
On Mon 29 Aug 2022 at 17:45, Huzi Cheng @.> wrote: @chenghuzi https://github.com/chenghuzi I need a method to show a particular drive. Do we have that? @chenghuzi https://github.com/chenghuzi do we have this feature implemented in #543 <#543> ? Do you anticipate any other blockers for this tutorial to be finished? That's hard. We can turn on the selected_index but since the drive tab is usually very long so setting index to the one we want to see won't help. To do that you need to scroll, but that requires manipulation with javascript. — Reply to this email directly, view it on GitHub <#535 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADY6FIUWSYGG3GBV2QN5SBDV3UVOLANCNFSM553NJW5A . You are receiving this because you authored the thread.Message ID: @.>
-- Sent from my iPhone

This is the expaned first drive:
image
We can only see about half of its height. So I don't think it will be that helpful. Besides, since we take the "screenshot" with Iframe, so the user can click the tab themselves

@jasmainak
Copy link
Collaborator Author

This is fine for me. Other alternative is to show only the widget of concern ... that is also pretty easy I believe through because the ipywidgets object stores the entire widget tree. Probably need a function to display that widget. Not sure which is better from the perspective of a user reading the tutorial ...

@jasmainak
Copy link
Collaborator Author

@chenghuzi feel free to take this over !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hnn-gui HNN GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants