Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

random fixes #2140

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

random fixes #2140

wants to merge 16 commits into from

Conversation

DinhHuy2010
Copy link

@DinhHuy2010 DinhHuy2010 commented Nov 18, 2024

What does this change

add dev-requirements.txt
fix mypy errors at generate_stubs.py
add doc at faker/__init__.py from README.rst
remove setup.py and MANIFEST.in for pyproject.toml

DO NOT MERGE THE PR! (until further edits)
More fixes coming soon.
Update: merge this (a.k.a. review this, more PRs will coming soon)

What was wrong

Nothing.

How this fixes it

Nothing.

Fixes #...

Checklist

  • I have read the documentation about CONTRIBUTING
  • I have read the documentation about Coding style
  • I have run make lint

@fcurella fcurella changed the title random fixes Draft: random fixes Nov 20, 2024
@fcurella fcurella marked this pull request as draft November 20, 2024 21:11
@DinhHuy2010 DinhHuy2010 marked this pull request as ready for review November 21, 2024 08:37
@DinhHuy2010 DinhHuy2010 changed the title Draft: random fixes random fixes Nov 21, 2024
@DinhHuy2010
Copy link
Author

@fcurella any update???

faker/__init__.py Show resolved Hide resolved
@DinhHuy2010 DinhHuy2010 requested a review from fcurella November 24, 2024 08:02
@DinhHuy2010
Copy link
Author

DinhHuy2010 commented Nov 28, 2024

MERGE CONFLICT!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants