test: fix undoc assumptions about the timing of tsfn calls

PR-URL: nodejs/node-addon-api#995 Reviewed-By: Michael Dawson <[email protected]>
johnfrench3 · May 11, 2021 · 60964c1 · 60964c1
1 parent 0c77003
commit 60964c1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/test/threadsafe_function/threadsafe_function.js b/test/threadsafe_function/threadsafe_function.js
@@ -25,11 +25,9 @@ async function test(binding) {
       binding.threadsafe_function[threadStarter](function testCallback(value) {
         array.push(value);
         if (array.length === quitAfter) {
-          setImmediate(() => {
-            binding.threadsafe_function.stopThread(common.mustCall(() => {
-              resolve(array);
-            }), !!abort);
-          });
+          binding.threadsafe_function.stopThread(common.mustCall(() => {
+            resolve(array);
+          }), !!abort);
         }
       }, !!abort, !!launchSecondary, maxQueueSize);
       if (threadStarter === 'startThreadNonblocking') {

diff --git a/test/typed_threadsafe_function/typed_threadsafe_function.js b/test/typed_threadsafe_function/typed_threadsafe_function.js
@@ -25,11 +25,9 @@ async function test(binding) {
       binding.typed_threadsafe_function[threadStarter](function testCallback(value) {
         array.push(value);
         if (array.length === quitAfter) {
-          setImmediate(() => {
-            binding.typed_threadsafe_function.stopThread(common.mustCall(() => {
-              resolve(array);
-            }), !!abort);
-          });
+          binding.typed_threadsafe_function.stopThread(common.mustCall(() => {
+            resolve(array);
+          }), !!abort);
         }
       }, !!abort, !!launchSecondary, maxQueueSize);
       if (threadStarter === 'startThreadNonblocking') {