Skip to content

Commit

Permalink
src: make 'nothing' target a static library
Browse files Browse the repository at this point in the history
This avoids the creation of `nothing.node` files in other projects.
These files will otherwise be identified as non-N-API modules, even
though they are empty.

PR-URL: nodejs/node-addon-api#348
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Nicola Del Gobbo <[email protected]>
  • Loading branch information
John French committed Sep 28, 2018
1 parent 8c51402 commit 2d4458f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/node_api.gyp
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
{
'targets': [
{
'target_name': 'nothing'
'target_name': 'nothing',
'type': 'static_library',
'sources': [ 'nothing.c' ]
},
{
'target_name': 'node-api',
Expand Down
Empty file added src/nothing.c
Empty file.

0 comments on commit 2d4458f

Please sign in to comment.