This repository has been archived by the owner on Jun 16, 2020. It is now read-only.
add ember-script support #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled. Ref: emberscript
I have come across a project where I am heavily developing in ember.js, and I adopted emberscript for the library.
I'd like to use emberscript in
jasmine-headless-webkittoo, but it seems that the supported Sprockets engines are hard-coded. I tried adding to it only in userland code, but it ended up being a large hack, cross-referencing and monkey-patchingjasmine-headless-webkititself all over the place.This PR adds emberscript support by hardcoding it into the library, just like how coffeescript is done. Not sure if I have done it The Right Way though, basically I just copied everything that is coffeescript-related, and made an emberscript version for it.
If it could be refactored to include only the needed extensions on-demand and allow userland injections of new Sprockets engines, then it would be perfect - but I don't know how to do it. As for the added heavyweight for a niche audience, well, IMHO
jsttemplates do not appear that often either. So I'd say the inclusion of emberscript is likewise justifiable simply as a harmless bonus feature like thejstcase.