Skip to content

Commit

Permalink
Removed check for ibl specular mipmap
Browse files Browse the repository at this point in the history
  • Loading branch information
jnsmalm committed Sep 11, 2020
1 parent f789f27 commit 94272ec
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
3 changes: 2 additions & 1 deletion src/material/standard/standard-material-feature-set.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { StandardMaterialDebugMode } from "./standard-material-debug-mode"
import { StandardMaterial } from "./standard-material"
import { LightingEnvironment } from "../../lighting/lighting-environment"
import { Mesh3D } from "../../mesh/mesh"
import { Platform } from "../../platform"

export namespace StandardMaterialFeatureSet {
export function build(renderer: PIXI.Renderer, mesh: Mesh3D, geometry: MeshGeometry3D, material: StandardMaterial, lightingEnvironment: LightingEnvironment) {
Expand Down Expand Up @@ -59,7 +60,7 @@ export namespace StandardMaterialFeatureSet {
if (!lightingEnvironment.imageBasedLighting.valid) {
return undefined
}
if (StandardMaterial.isImageBasedLightingSpecularMipmapSupported(renderer)) {
if (Platform.isShaderTextureLodSupported(renderer)) {
features.push("USE_TEX_LOD 1")
}
features.push("USE_IBL 1")
Expand Down
9 changes: 0 additions & 9 deletions src/material/standard/standard-material.ts
Original file line number Diff line number Diff line change
Expand Up @@ -206,15 +206,6 @@ export class StandardMaterial extends Material {
this._shader = undefined
}

/**
* Returns a value indicating if specular mipmap is supported by current
* platform when using image based lighting.
* @param renderer The renderer to use.
*/
static isImageBasedLightingSpecularMipmapSupported(renderer: PIXI.Renderer) {
return Platform.isShaderTextureLodSupported(renderer)
}

/**
* Creates a standard material factory which can be used when loading models.
* @param properties Properties to set on the material when created.
Expand Down

0 comments on commit 94272ec

Please sign in to comment.