Merge pull request #57 from mtichner/patch-1

Allow comparison of Integers and Numeric types
jmespath · Nov 25, 2022 · 9c7d316 · 9c7d316
2 parents a085656 + 90ab191
commit 9c7d316
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,8 @@
 Unreleased Changes
 ------------------
 
+* Issue - Allow comparison of Numeric types (includes Float).
+
 * Issue - Add jmespath.rb to gemspec executables.
 
 1.6.1 (2022-03-07)

diff --git a/lib/jmespath/nodes/condition.rb b/lib/jmespath/nodes/condition.rb
@@ -28,7 +28,7 @@ def optimize
 
     class ComparatorCondition < Node
       COMPARATOR_TO_CONDITION = {}
-      COMPARABLE_TYPES = [Integer, String].freeze
+      COMPARABLE_TYPES = [Numeric, String].freeze
 
       def initialize(left, right, child)
         @left = left

diff --git a/spec/compliance/filters.json b/spec/compliance/filters.json
@@ -465,6 +465,33 @@
       }
     ]
   },
+  {
+    "given": {"foo": [{"length": 170},
+      {"length": 175.5},
+      {"length": 185}]},
+    "cases": [
+      {
+        "comment": "Less than number",
+        "expression": "foo[?length < `180`]",
+        "result": [{"length": 170}, {"length": 175.5}]
+      },
+      {
+        "comment": "Less than or equal to number",
+        "expression": "foo[?length <= `175.5`]",
+        "result": [{"length": 170}, {"length": 175.5}]
+      },
+      {
+        "comment": "Greater than number",
+        "expression": "foo[?length > `170`]",
+        "result": [{"length": 175.5}, {"length": 185}]
+      },
+      {
+        "comment": "Greater than or equal to number",
+        "expression": "foo[?length >= `175.5`]",
+        "result": [{"length": 175.5}, {"length": 185}]
+      }
+    ]
+  },
   {
     "given": {
       "foo": ["2010-02-01", "2011-05-01"]