Tidal prf #5
Merged
Tidal prf #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prevent nan values for zero-frequency component in spectrum Previously providing a zero frequency when creating a spectrum (JONSWAP or Pierson Moskowitz) produced a NaN value. This is due the f^-5 and f^-4 terms in the calculation. The zero frequency is a valid input and is important when calculating the surface elevation from the spectrum. We know, however, that the zero frequency should __always__ have zero amplitude as the surface elevation has a mean of zero. This change ensures that if a zero frequency is provided, the amplitude is set to zero. * Compute surface elevation using IFFT Previously the surface elevation was only computed using the 'sum of sines' method. This has been found to be prohibitively slow when computing long duration surface elevation traces. This commit introduces the capability to compute the surface elevation using the more computationally efficient IFFT. The IFFT routine is used by default if no frequency bins are provided and the input frequency vector is equally spaced. For example a 1hr sea state realisation at 20Hz took 11s to compute using the 'sum of sines' and 0.007s using the IFFT. Fixes MHKiT-Software#229 * add docstrings to surface_elevation * update surface_elevation calls in examples --------- Co-authored-by: akeeste <[email protected]>
A slew of bugfixes and inconsistency cleanup, as well as including ADCP turbulence functionality for MHKiT-Software#227 Changelog: Bugfixes Added check to ensure n_bin is shorter than the total data length when calling dolfyn.TimeBinner.reshape Added checks to ensure n_fft and n_fft_coh can't be greater than n_bin Fixed bug where dolfyn.adp.nan_beyond_surface overtrimmed TRDI instrument data Fixed bug where dolfyn.ADVBinner.cross_spectral_density would fail if n_fft != n_fft_coh Improved robustness of Nortek Signature reader for deployments not measuring water velocity log file extension changed from ".log" to ".dolfyn.log" API/Useability Calculation of depth from pressure sensor updated to use linear approximation of the equation of state, rather than EOS-80 Added warnings for ADV motion and turbulence functions Updated dataset.velds.U_dir shortcut to automatically convert "degrees CCW from X/East/streamwise" to "degrees CW from X/North/streamwise" dolfyn.ADVBinner.cross_spectral_density now returns frequency coordinate coh_freq instead of freq Added ADCP turbulence functions Added function to calculate Doppler noise to ADV turbulence functions Added "beam_angle" attribute to Nortek Signature datasets Saved full Nortek Signature "config" dictionary as json string in attributes Added warning if "rotate_vars" attribute not found Standardized variable metadata based on CF conventions
4 tasks
jmcvey3
pushed a commit
that referenced
this pull request
Jul 2, 2024
* fix cdip * D3D TRTS eg fix * fix pylint error * pylint * fix too many branches * fix map and Tp * folium fix & Tp using pandas * up to python 3.10 * py version as string * fix variable check for new xarray * undo changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge MHKiT-Software#232 & resolve conflicts in adcp example